Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unify returning queries #17157

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: unify returning queries #17157

wants to merge 3 commits into from

Conversation

lohart13
Copy link
Contributor

@lohart13 lohart13 commented Mar 10, 2024 •
edited

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description of Changes

This is another change split from #16988.

This PR unifies the way data from the database is mapped to a Model instance for inserts, updates and upserts.

List of Breaking Changes

SQLite now supports returning database values from inserts, updates and upserts.

@lohart13 lohart13 requested a review from a team as a code owner March 10, 2024 23:35
@lohart13 lohart13 requested review from ephys and WikiRik March 10, 2024 23:35
@lohart13
Copy link
Contributor Author

This should be good to go now.
The single failing test is due to the artifact not being downloaded successfully.

@WikiRik WikiRik mentioned this pull request Mar 22, 2024
Open
5 tasks
@lohart13 lohart13 force-pushed the fix-return-methods branch 4 times, most recently from 6088347 to 01f5ac6 Compare March 27, 2024 21:55
@sequelize-bot sequelize-bot bot added the conflicted This PR has merge conflicts and will not be present in the list of PRs to review label Apr 10, 2024
@sequelize-bot sequelize-bot bot removed the conflicted This PR has merge conflicts and will not be present in the list of PRs to review label Apr 12, 2024
@lohart13 lohart13 force-pushed the fix-return-methods branch 2 times, most recently from d3f6853 to df30b20 Compare April 16, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik approved these changes

@ephys ephys Awaiting requested review from ephys ephys is a code owner automatically assigned from sequelize/code-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lohart13 @WikiRik