Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve default value parsing #17124

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Conversation

ghusse
Copy link
Contributor

@ghusse ghusse commented Feb 26, 2024

Linked to #16787

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description of Changes

List of Breaking Changes

const dialect = Support.getTestDialect();

if (dialect.startsWith('mysql')) {
describe('[MySQL Specific] parseDefaultValue', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might already be aware of this, but we have a helper function called expectPerDialect which you can use to add different assertions based on the dialect you are testing on. We prefer that that is used instead of adding dialect-specific test suites. It's fine while you are working on this, but I just wanted to bring it to your attention before the initial review

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think I'll use that in the general integration test of describeTable.

I don't think that could be usefull in the situation of testing default-value-parser with unit test, because tested cases heavily depend on the dialect too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants