New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve default value parsing #17124
base: main
Are you sure you want to change the base?
Conversation
const dialect = Support.getTestDialect(); | ||
|
||
if (dialect.startsWith('mysql')) { | ||
describe('[MySQL Specific] parseDefaultValue', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might already be aware of this, but we have a helper function called expectPerDialect
which you can use to add different assertions based on the dialect you are testing on. We prefer that that is used instead of adding dialect-specific test suites. It's fine while you are working on this, but I just wanted to bring it to your attention before the initial review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think I'll use that in the general integration test of describeTable
.
I don't think that could be usefull in the situation of testing default-value-parser
with unit test, because tested cases heavily depend on the dialect too.
Linked to #16787
Pull Request Checklist
Description of Changes
List of Breaking Changes