New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: overhaul test suite of attribute(s)ToSQL
#17121
base: main
Are you sure you want to change the base?
Conversation
@ephys even though it's in draft; could you take a look at the test cases that we do? As mentioned in the TODOs above, there is still work to be done but I want to confirm that this is how people can use these functions before cleaning up test suites and add typings. |
I'll mark it as ready for review since the bulk of the work is done. It's not ready for merging yet, since I want to know if there's any tests that have unwanted behaviour before I work on typing the functions. |
Description of Changes
Attempt 2 on overhauling the test suite for
attributesToSQL
andattributeToSQL
. I also did some minor improvements to the functions.Closes #15533
TODOs
attributeToSQL
attributesToSQL
Future PRs
attributesToSql
andattributeToSql
respectivelyattributesToSQL
to queryGenerator so both can become internal functionscomment
for sqlite)attribute(s)ToSQL
(breaking change)List of Breaking Changes