Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mssql): do not add PK of model to order by when order exists #16776

Open
wants to merge 7 commits into
base: v6
Choose a base branch
from
Open

fix(mssql): do not add PK of model to order by when order exists #16776

wants to merge 7 commits into from

Conversation

aniruth37
Copy link

@aniruth37 aniruth37 commented Nov 17, 2023 •
edited

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

PR should fix #14185

Primary Key of the Model should not be added to the Order By clause when an order is provided

@aniruth37 aniruth37 mentioned this pull request Nov 17, 2023
Open
8 tasks
@WikiRik WikiRik added the v6 label Dec 22, 2023
@aniruth37
Copy link
Author

@WikiRik , @ephys
Could you please review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-arya95 rishabh-arya95 rishabh-arya95 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
v6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aniruth37 @rishabh-arya95 @WikiRik