fix: filter also on schema name when retrieving foreign keys #16770
Conversation
ghusse
force-pushed
the
fix/relationships-multiple-schemas
branch
from
d8c1be1
to
ba945ef
Compare
ghusse
changed the title
ghusse
changed the title
|
PR #16785 on v7 shows that this issue is already fixed on v7, but I'm interested in a fix in v6 as well. |
|
@WikiRik, the PR on v7 has been merged. Is it possible to merge this one as well? It fixes an issue with foreign keys retrieval. |
| @@ -40,5 +40,51 @@ describe(Support.getTestDialectTeaser('QueryInterface'), () => { | |||
| expect(refs[0]).deep.include.all(expectedObject); | |||
|
|
|||
| }); | |||
|
|
|||
| describe('with schemas', () => { | |||
| // MariaDB does not really support schemas (they are synonyms of databases) | |||
There was a problem hiding this comment.
Is this behaviour different between mariadb and mysql?
There was a problem hiding this comment.
For MySQL, Support.sequelize.dialect.supports.schemas is false, but for MariaDB it's true (even though it does not really support schemas).
You can see it there:
|
This would be a breaking change though, as the behavior would change. It would be better to do this in v7 |
I added tests in v7 to check that it's already working as expected (and it is). I agree that the behavior will change, but the behavior is buggy. For instance in PG, there is a condition to retrieve info only about the table in the right schema, but the condition has not been added to the JOIN conditions. Meaning that it'll retrieve foreign keys of tables with the same name from other schemas. |
Pull Request Checklist
Description Of Change
When retrieving the list of foreign keys of a table on Postgresql, relationships are not filtered by schema. It means that if a different schema contains the same table,
getForeignKeyReferencesForTablewill also return relationships of this second table.This PR fixes this issue by filtering also by database name and schema name to be sure that only FKs from the requested table are retrieved.