Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: self referencing with through table where-clause clashes with the included models #16768

Open
wants to merge 1 commit into
base: v6
Choose a base branch
from

Conversation

shawara
Copy link

@shawara shawara commented Nov 16, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Fix self-reference with though table where-clause in include not working correctly because top parent name in the where-clause clashes with the included models.
Closes #16719

@shawara shawara changed the title fix: self reference with through table query fix: self referencing with through table where-clause clashes with the included models Nov 16, 2023
@shawara
Copy link
Author

shawara commented Dec 18, 2023

@WikiRik could you review it?

@WikiRik WikiRik added the v6 label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants