Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop support for Node 14 and add for Node 20 #16058

Merged
merged 11 commits into from Jun 19, 2023
Merged

feat: drop support for Node 14 and add for Node 20 #16058

merged 11 commits into from Jun 19, 2023

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented May 24, 2023 •
edited

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

This PR drops the support for Node 14 since it's been EOL since eind of April 2023.
In related news, Node 20 testing will be added when Node 20 is in LTS.

Unblocks #15928

Commit message


BREAKING CHANGE: Sequelize now requires Node >=16.0.0

@WikiRik WikiRik mentioned this pull request May 24, 2023
Merged
@WikiRik WikiRik marked this pull request as ready for review May 24, 2023 20:05
@WikiRik WikiRik requested a review from a team May 24, 2023 20:05
ephys
ephys previously approved these changes Jun 17, 2023
View reviewed changes
@ephys
Copy link
Member

ephys commented Jun 17, 2023 •
edited

@WikiRik small conflict :(

Sorry I never saw this PR before

ephys
ephys previously approved these changes Jun 17, 2023
View reviewed changes
@ephys ephys enabled auto-merge June 17, 2023 14:59
@ephys ephys disabled auto-merge June 17, 2023 14:59
@ephys
Copy link
Member

ephys commented Jun 17, 2023

Uh, the merge queue does not let us change the merge description to include the BREAKING CHANGE tag (not all config generators support !, I hope lerna does)

@ephys ephys enabled auto-merge June 17, 2023 15:00
@WikiRik WikiRik disabled auto-merge June 17, 2023 15:02
@WikiRik
Copy link
Member Author

WikiRik commented Jun 17, 2023

I also forgot to include the breaking change tag, so we should indeed merge this manually

@ephys
Copy link
Member

ephys commented Jun 17, 2023

That means we need to disable the merge queue to merge this PR / https://github.com/orgs/community/discussions/15925

@WikiRik WikiRik mentioned this pull request Jun 18, 2023
Merged
5 tasks
@WikiRik WikiRik marked this pull request as draft June 18, 2023 15:47
@WikiRik
Copy link
Member Author

WikiRik commented Jun 18, 2023

When we merge this, we need to update the required checks as well

@ephys how did you get the commit body in the mariadb connector upgrade merge? Did you disable the merge queue temporarily in the settings?

@WikiRik WikiRik changed the title feat!: drop support for Node 14 feat: drop support for Node 14 Jun 19, 2023
@WikiRik WikiRik marked this pull request as ready for review June 19, 2023 06:08
@WikiRik WikiRik requested a review from ephys June 19, 2023 06:08
@ephys
Copy link
Member

ephys commented Jun 19, 2023

While doing this, should we set the latest node version to 20 in the same PR?

@WikiRik
Copy link
Member Author

WikiRik commented Jun 19, 2023

While doing this, should we set the latest node version to 20 in the same PR?

I wrote this in the description; "In related news, Node 20 testing will be added when Node 20 is in LTS."
We did the same for Node 18 iirc

@ephys
Copy link
Member

ephys commented Jun 19, 2023 •
edited

Sorry I did not see that
We added support for 18 in May June to be ready by the time it becomes LTS (#14415)

@WikiRik
Copy link
Member Author

WikiRik commented Jun 19, 2023 •
edited

Ah, I see. I wanted to wait, but in the end we didn't. I'll add Node 20 in a different PR soon in case not all dependencies are ready

@ephys
Copy link
Member

ephys commented Jun 19, 2023

Ok!

ephys
ephys previously approved these changes Jun 19, 2023
View reviewed changes
@WikiRik WikiRik changed the title feat: drop support for Node 14 feat: drop support for Node 14 and add for Node 20 Jun 19, 2023
@WikiRik
Copy link
Member Author

WikiRik commented Jun 19, 2023

Okay, nevermind. It didn't complain about dependencies so I changed it here

@WikiRik WikiRik merged commit 39bf550 into main Jun 19, 2023
50 checks passed
@WikiRik WikiRik deleted the WikiRik/node-16 branch June 19, 2023 20:48
@wellwelwel wellwelwel mentioned this pull request Jun 19, 2023
Open
@Hornwitser Hornwitser mentioned this pull request Aug 29, 2023
Closed
6 tasks
Hornwitser added a commit to Hornwitser/sequelize-sscce that referenced this pull request Aug 29, 2023
@Hornwitser
fix: make CI pipeline run v7 on Node.js >= 16
c25f3ee 
With sequelize/sequelize#16058 v14 is no longer supported on Sequelize
v7.  Update the CI pipeline to only run v7 tests if Node.js version is
16 or higher.

Also fix sqlite tests only being ran on Node.js v14.
@Hornwitser Hornwitser mentioned this pull request Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephys ephys ephys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WikiRik @ephys