Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix parameters not being replaced when after $$ strings #15306

Merged
merged 3 commits into from
Nov 19, 2022
Merged

fix: fix parameters not being replaced when after $$ strings #15306

merged 3 commits into from
Nov 19, 2022

Conversation

ephys
Copy link
Member

@ephys ephys commented Nov 19, 2022 •
edited

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

V7 version of #15307

Fix issue described in #15301 (comment)

@ephys ephys self-assigned this Nov 19, 2022
@ephys ephys mentioned this pull request Nov 19, 2022
Merged
5 tasks
fzn0x
fzn0x approved these changes Nov 19, 2022
View reviewed changes
Copy link
Member

@fzn0x fzn0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was amazed to see that it was done with a ?? ''

@ephys ephys merged commit 1a47fea into main Nov 19, 2022
@ephys ephys deleted the ephys/replacement-fix branch November 19, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik approved these changes

@fzn0x fzn0x fzn0x approved these changes

Assignees

@ephys ephys

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ephys @WikiRik @fzn0x