New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): add TypeScript 4.8 compatibility #14996
Conversation
Thank you! Can you remove TS 4.4 from this array, and add 4.8 at its end? |
dc16250
to
c68f281
Compare
Also, I think it would be better if this is a |
Damn I should have read this before merging the other one, v6 was merged as feat |
c68f281
to
5a156d4
Compare
I've updated commit message and PR title to use |
5a156d4
to
9cb38cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that it doesn't pass the lint anymore. Can you remove as any
from the src/utils/sql.ts
file
I think that's going to cause older typescript versions to fail. Muting the lint error could resolve the issue |
That's very possible. Muting would also be fine for now |
9cb38cb
to
908c412
Compare
There was an additional error related to https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/#lib-d-ts-updates. Ready to review again! |
Thank you for making this PR :) |
🎉 This PR is included in version 7.0.0-alpha.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull Request Checklist
Please make sure to review and check all of these items:
yarn test
oryarn test-DIALECT
pass with this change (including linting)?Description Of Change
Sequelize typings are affected in a few places by a TypeScript 4.8 breaking change (https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/#unconstrained-generics-no-longer-assignable-to).
The PR brings changes from #14990 (which closes #14934) to
main
branch.