Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove additional fake timer #14401

Merged
merged 2 commits into from
Apr 15, 2022
Merged

test: remove additional fake timer #14401

merged 2 commits into from
Apr 15, 2022

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Apr 15, 2022

Pull Request Checklist

Please make sure to review and check all of these items:

  • Have you added new tests to prevent regressions?
  • Does yarn test or yarn test-DIALECT pass with this change (including linting)?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

#14390 is currently failing due to sinonjs/fake-timers#426
This should solve it. I did update the Model upsert works when two separate uniqueKeys are passed test to remove the timing check since that is not part of what is being tested.

As a future refactor we should look into the usage of fakeTimers and see if they are not used too often

@WikiRik WikiRik requested a review from a team April 15, 2022 14:17
@WikiRik WikiRik merged commit 30fd449 into main Apr 15, 2022
@WikiRik WikiRik deleted the WikiRik/faketimers branch April 15, 2022 15:53
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.0.0-alpha.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

vanthome pushed a commit to vanthome/sequelize that referenced this pull request Jun 12, 2022
* test: remove additional fake timer

* test: revert non essential changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants