Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): make Model.init aware of pre-configured foreign keys #14370

Merged
merged 2 commits into from Apr 12, 2022

Conversation

ephys
Copy link
Member

@ephys ephys commented Apr 12, 2022

Backporting #14148 to v6

Related documentation PR: sequelize/website#79

Closes #14365

@ephys ephys added the type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. label Apr 12, 2022
@ephys ephys self-assigned this Apr 12, 2022
ephys added a commit to sequelize/website that referenced this pull request Apr 12, 2022
@ephys ephys requested a review from a team April 12, 2022 12:42
WikiRik
WikiRik previously approved these changes Apr 12, 2022
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as well.

Btw; do you plan on backporting more typings to v6?

@ephys
Copy link
Member Author

ephys commented Apr 12, 2022

Hopefully not. I was already done with v6 (the merge conflicts are getting very hard to reconcile) but these two things were an issue for enough people to be worth it

@ephys
Copy link
Member Author

ephys commented Apr 12, 2022

Simple merge of the v6 branch. But I also accidentally updated our lockfile. It's likely fine though

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine, otherwise we can regenerate the lockfile in a separate PR

@ephys ephys merged commit 5954d2c into v6 Apr 12, 2022
@ephys ephys deleted the ephys/backport-foreign-key-type branch April 12, 2022 14:58
ephys added a commit to sequelize/website that referenced this pull request Apr 12, 2022
@github-actions
Copy link
Contributor

🎉 This PR is included in version 6.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fabrykowski fabrykowski mentioned this pull request May 11, 2022
5 tasks
aliatsis pushed a commit to creditiq/sequelize that referenced this pull request Jun 2, 2022
gaspardmonet added a commit to gaspardmonet/website that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants