Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
oryarn test-DIALECT
pass with this change (including linting)?Description Of Change
This PR prevents users from importing anything other than
@sequelize/core
and@sequelize/core/package.json
.With this change, it is safe to rework our internal source code without risking to introduce a breaking change.
If users need to access our internals, they should open a feature request so we can expose a properly tested solution.
Breaking change documented: sequelize/website#78
As a last resort, if a user really needs to access them, I added
@sequelize/core/_non-semver-use-at-your-own-risk_
as an alias for@sequelize/core/lib
. Hopefully it is clear enough that these imports should only be used as a last resort and are not officially supported, and could break in any release, including patch releases.