New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency expect-type to v0.13.0 #14032
Conversation
@ephys could you maybe take a look at this in the coming week or so? |
I've tried but I can't manage to make the typing tests for the mutability of hooks options work in TS [4.2,4.4] :/ |
Do you think it's a bug with expect-type or with our typings? |
I managed to narrow the issue down to Since the test passes starting with TS 4.5, I think our code might be correct. It might be a limitation of TS < 4.5. Not sure why it works in TS 4.1. I'm pretty sure TS < 4.5 does not like us mapping the entries of an array. Looked into whether other libraries had implemented this, such as type-fest but did not find anything. I was still sick when I looked into this, we could look for more implementations of a DeepMutable type and see if it's done differently. |
18373d8
to
bc432c6
Compare
I think I like that proposition, shall we add that in a separate PR and then merge this update afterwards? |
I'll reset this PR and do it here, so we can make sure the typing tests are passing :) |
efe0274
to
353a841
Compare
353a841
to
a5362d6
Compare
It seems to work now in 4.4 so I guess we can merge this |
That could mean I broke something in #14368 |
π This PR is included in version 7.0.0-alpha.11 π The release is available on: Your semantic-release bot π¦π |
Co-authored-by: Renovate Bot <bot@renovateapp.com>
This PR contains the following updates:
0.12.0
->0.13.0
Release Notes
mmkal/ts
v0.13.0
minor changes
Configuration
π Schedule: At any time (no schedule defined).
π¦ Automerge: Disabled by config. Please merge this manually once you are satisfied.
β» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
π Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.