Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document breaking change from #13951 #14005

Merged
merged 1 commit into from Jan 24, 2022

Conversation

ephys
Copy link
Member

@ephys ephys commented Jan 24, 2022

Pull Request Checklist

  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

I did not realize #13951 was a breaking change. #14003 reported breakage following that change.

PR #14004 rolls back the change in v6.
We're keeping the change in v7, and this PR documents the change in upgrade-to-v7.md.

@ephys ephys added the type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference. label Jan 24, 2022
@ephys ephys self-assigned this Jan 24, 2022
@ephys ephys requested a review from WikiRik January 24, 2022 18:50
@fzn0x fzn0x merged commit cd097ce into main Jan 24, 2022
@fzn0x fzn0x deleted the ephys/v7-document-overloaded-method-change branch January 24, 2022 21:45
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

🎉 This PR is included in version 7.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @v7 type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants