Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't call overloaded versions of find functions internally #13951

Merged
merged 5 commits into from Jan 15, 2022
Merged

fix: don't call overloaded versions of find functions internally #13951

merged 5 commits into from Jan 15, 2022

Commits on Jan 15, 2022

  1. fix: add failing tests for calling overridden methods 

    This was lost in sequelize#5924, but the comments remained, rendering them
contradictory. The tests demonstrate that the commented behavior is no
longer happening.
    @cincodenada
    cincodenada committed Jan 15, 2022
    Copy the full SHA
    f63920e View commit details
    Browse the repository at this point in the history

  2. fix: don't call overloaded find methods internally 

    This aligns our behavior with the comments again
    @cincodenada
    cincodenada committed Jan 15, 2022
    Copy the full SHA
    4058e72 View commit details
    Browse the repository at this point in the history

  3. fix: fix test setup for new test

    @cincodenada
    cincodenada committed Jan 15, 2022
    Copy the full SHA
    752665e View commit details
    Browse the repository at this point in the history

  4. fix: make naming of model unit tests consistent 

    These were all over the place, I went with what seems to be the majority
    @cincodenada
    cincodenada committed Jan 15, 2022
    Copy the full SHA
    e56bdb8 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into no-call-overloads

    @ephys
    ephys committed Jan 15, 2022
    Copy the full SHA
    d9c220a View commit details
    Browse the repository at this point in the history