Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(model.d): fix findAndCountAll.count type #13736

Merged
merged 6 commits into from Dec 17, 2021
Merged

fix(model.d): fix findAndCountAll.count type #13736

merged 6 commits into from Dec 17, 2021

Commits on Dec 3, 2021

  1. fix(model.d): fix findAndCountAll.count type 

    `findAndCountAll` should only return `count` as an array when the `group` option is provided.

This means in that case, `options` is no longer optional because when `options` is not provided, it's never a group count.
I also rearrange `findAndCountAll` order to ensure the single count overload is applied first.
    @zorji
    zorji committed Dec 3, 2021
    Copy the full SHA
    987d177 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. refactor(model): add fix type for findAllAndCount

    @zorji
    zorji committed Dec 13, 2021
    Copy the full SHA
    223aee9 View commit details
    Browse the repository at this point in the history

  2. refactor(model): tidy up type with SetRequired

    @zorji
    zorji committed Dec 13, 2021
    Copy the full SHA
    3004a2f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into patch-1

    @sdepold
    sdepold committed Dec 13, 2021
    Copy the full SHA
    3fa3087 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. Merge branch 'main' into patch-1

    @sdepold
    sdepold committed Dec 14, 2021
    Copy the full SHA
    fa829ae View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2021

  1. Merge branch 'main' into patch-1

    @sdepold
    sdepold committed Dec 17, 2021
    Copy the full SHA
    162d2b0 View commit details
    Browse the repository at this point in the history