Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add hooks to InstanceDestroyOptions type #13491

Merged
merged 6 commits into from Jan 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/lib/model.d.ts
Expand Up @@ -959,7 +959,7 @@ export interface InstanceRestoreOptions extends Logging, Transactionable { }
/**
* Options used for Instance.destroy method
*/
export interface InstanceDestroyOptions extends Logging, Transactionable {
export interface InstanceDestroyOptions extends Logging, Transactionable, Hookable {
/**
* If set to true, paranoid models will actually be deleted
*/
Expand Down
14 changes: 14 additions & 0 deletions types/test/destroy.ts
@@ -0,0 +1,14 @@
import { User } from './models/User';

(async () => {
const user = await User.create();

await user.destroy({
hooks: true
});

await User.destroy({
hooks: false,
where: { firstName: 'John' }
});
})();