New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: source/target keys in belongsToMany associations #11311
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11311 +/- ##
==========================================
+ Coverage 96.35% 96.35% +<.01%
==========================================
Files 94 94
Lines 9071 9089 +18
==========================================
+ Hits 8740 8758 +18
Misses 331 331
Continue to review full report at Codecov.
|
Need some help with test coverage, what I'm doing wrong 😄 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great PR!
Thank you very much for investing some time to help Sequelize!
(Let's see what @sushantdhiman has to say!)
I don't see anything wrong with the coverage 👍 |
🎉 This PR is included in version 5.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull Request check-list
Please make sure to review and check all of these items:
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description of change
Closes #4092