Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(association): Name model that association is missing from #11290

Merged
merged 1 commit into from Aug 9, 2019

Conversation

chrisjensen
Copy link
Contributor

@chrisjensen chrisjensen commented Aug 7, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? N/A
  • Did you update the typescript typings accordingly (if applicable)? N/A
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

As the missing include error comes up in async code, it can be hard to trace the caller and source of the issue.
Propose adding the name of the model that the association cannot be found on so as to give more context for debugging.

As the missing include error comes up in async code, it can be hard to trace the caller.
Propose adding the name of the model that the association cannot be found on so as to give more context for debugging.
@papb papb added status: awaiting maintainer type: other For issues and PRs. Something that does not fit in any of the other "type:" labels. labels Aug 7, 2019
@sushantdhiman sushantdhiman merged commit dd428a0 into sequelize:master Aug 9, 2019
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 5.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released type: other For issues and PRs. Something that does not fit in any of the other "type:" labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants