Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix parameters not being replaced when after $$ strings #15307

Merged
merged 1 commit into from Nov 19, 2022

Conversation

ephys
Copy link
Member

@ephys ephys commented Nov 19, 2022

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

V6 version of #15306

Closes #15301

Fix issue described in #15301 (comment)

@ephys ephys merged commit bc39fd6 into v6 Nov 19, 2022
@ephys ephys deleted the ephys/replacement-fix-v6 branch November 19, 2022 16:13
@github-actions
Copy link
Contributor

🎉 This PR is included in version 6.25.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacements don't work properly when using $$ to tell the start and end of function
3 participants