Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(model): Added paranoid option for Model.BelongsToMany.through #15065

Merged
merged 4 commits into from Sep 30, 2022
Merged

docs(model): Added paranoid option for Model.BelongsToMany.through #15065

merged 4 commits into from Sep 30, 2022

Conversation

ajatdarojat45
Copy link

@ajatdarojat45 ajatdarojat45 commented Sep 29, 2022 •
edited by fzn0x

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Because in Model.BelongsToMany.through documentation there is no paranoid option so i added it in documentation.

@ajatdarojat45 ajatdarojat45 mentioned this pull request Sep 29, 2022
Closed
@ajatdarojat45 ajatdarojat45 changed the title add Model.BelongsToMany.through.paranoid option in documentation docs(model): Added Model.BelongsToMany.through.paranoid option in the documentation Sep 29, 2022
@ajatdarojat45 ajatdarojat45 changed the title docs(model): Added Model.BelongsToMany.through.paranoid option in the documentation docs(model): Added paranoid option for Model.BelongsToMany.through Sep 29, 2022
WikiRik
WikiRik requested changes Sep 29, 2022
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert all the style changes?

@WikiRik WikiRik requested a review from ephys September 29, 2022 13:57
@ajatdarojat45
Update model.js
b5e23e9 
add paranoid option for Model.BelongsToMany.through
@ajatdarojat45
Copy link
Author

Hi @WikiRik thank you for reply my PR. i have changed my style changes. let me know if there are any questions

WikiRik
WikiRik reviewed Sep 29, 2022
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the description not the same as in ThroughOptions? See the snippet below

sequelize/src/associations/belongs-to-many.d.ts

Lines 27 to 31 in 7203b66

/**
* If true the generated join table will be paranoid
* @default false
*/
paranoid?: boolean;

@ajatdarojat45
add paranoid option in Model.BelongsToMany.through
811191a 
sync description paranoid option with belongs-to-many.d.ts
@ajatdarojat45
Copy link
Author

i am sorry i miss it. i have changed it @WikiRik

@fzn0x fzn0x added the type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference. label Sep 29, 2022
@WikiRik WikiRik merged commit 5c88734 into sequelize:v6 Sep 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

🎉 This PR is included in version 6.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephys ephys ephys approved these changes

@WikiRik WikiRik WikiRik approved these changes

@fzn0x fzn0x fzn0x approved these changes

Assignees
No one assigned
Labels
released type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ajatdarojat45 @ephys @WikiRik @fzn0x