feat(types): add typescript 4.8 compatibility #14990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzn0x
reviewed
Sep 16, 2022
|
Thanks for the PR! Are you willing to make a PR towards the main branch as well? |
ephys
requested changes
Sep 17, 2022
There was a problem hiding this comment.
Other than that, if tests pass (and they do), lgtm!
I think the type test suite here should already cover everything that has been impacted https://github.com/sequelize/sequelize/tree/main/test/types
ephys
changed the title
bnorbi95
force-pushed
the
typescript-4.8-types
branch
from
6660a18
to
aa3bfae
Compare
ephys
approved these changes
Sep 17, 2022
6 tasks
fzn0x
approved these changes
Sep 17, 2022
|
Failing tests are flaky tests, we can merge |
|
🎉 This PR is included in version 6.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thank you for the initiatives! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please make sure to review and check all of these items:
yarn testoryarn test-DIALECTpass with this change (including linting)?Description Of Change
Sequelize typings are affected in a few places by a TypeScript 4.8 breaking change (https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/#unconstrained-generics-no-longer-assignable-to).
This PR addresses #14934.