Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include DRAGEN metrics in MULTIQC report #2

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

RHReynolds
Copy link
Contributor

Major changes include:

Minor changes include:

  • Addition of the arm profile for docker (testing on a mac, sorry!)
  • Addition of ${meta.id}/ to the publishDir for the DRAGEN modules, so that DRAGEN outputs are stored in separate folders for each sample

PR checklist

  • This comment contains a description of changes (with reason).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • CHANGELOG.md is updated.

Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thanks @RHReynolds ! 😍

Maybe we can use -stub to run the tests given we can't really test DRAGEN via native Github Actions machines. Hopefully, that will give us something to test though for CI/CD.

@RHReynolds
Copy link
Contributor Author

That sounds like a good idea. Do you know of a way to run -stub only for particular processes?

I ended up removing the stub part of the multiqc script (see multiqc.diff), just to check whether the stub part of the dragen script had worked, and prompted multiqc.

We could do the same for other nf-core modules, and just introduce a .diff patch, but thought I'd check if there's another/better way of doing it :)

Happy to implement whichever strategy in this PR, or a new PR, if that's more appropriate.

@adamrtalbot adamrtalbot mentioned this pull request May 29, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants