Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Russian Fonts Added #219

Merged
merged 19 commits into from Feb 12, 2023
Merged

New Russian Fonts Added #219

merged 19 commits into from Feb 12, 2023

Conversation

sadrasabouri
Copy link
Collaborator

@sadrasabouri sadrasabouri commented Feb 9, 2023

Reference Issues/PRs

#207

What does this implement/fix? Explain your changes.

  • 6 new fonts added
    1. small_fancy
    2. boom
    3. cross_jesus
    4. dark_tattoo
    5. lucifer
    6. ascii_roman

Also below notes are worth mentioning:

  • minor changes are needed for boom font to be added.

@sadrasabouri sadrasabouri self-assigned this Feb 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Merging #219 (3215fb7) into dev (1f43b52) will increase coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev     #219      +/-   ##
==========================================
+ Coverage   99.83%   99.83%   +0.01%     
==========================================
  Files           7        7              
  Lines        1164     1170       +6     
  Branches       74       74              
==========================================
+ Hits         1162     1168       +6     
  Misses          1        1              
  Partials        1        1              
Impacted Files Coverage Δ
art/art_param.py 100.00% <ø> (ø)
art/art.py 99.28% <100.00%> (ø)
art/text_dic3.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sepandhaghighi sepandhaghighi added this to the art 5.9 milestone Feb 11, 2023
art/text_dic3.py Outdated
'9': '9',
' ': ' '}

scary_dic = {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This font (scary) mapping seems wrong!!
It would be better to remove it!

Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@sepandhaghighi sepandhaghighi merged commit 0870f9c into dev Feb 12, 2023
@sepandhaghighi sepandhaghighi deleted the new-russian-fonts branch February 12, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants