Playing cards added #156
Merged
Playing cards added #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #156 +/- ##
=======================================
Coverage 90.88% 90.88%
=======================================
Files 1 1
Lines 274 274
Branches 74 74
=======================================
Hits 249 249
Misses 23 23
Partials 2 2 Continue to review full report at Codecov.
|
sadrasabouri
commented
Mar 13, 2021
art/art_dic.py
Outdated
| "playing cards clubs": "[♣]]]", | ||
| "playing cards clubs waterfall": "🃏🃑🃒🃓🃔🃕🃖🃗🃘🃙🃚🃛🃜🃝🃞", | ||
| "playing cards spades": "[♠]]]", | ||
| "playing cards spades waterfall": "🃠" + "🂡🂢🂣🂤🂥🂦🂧🂨🂩🂪🂫🂬🂭🂮", |
There was a problem hiding this comment.
Here, two string are concatenated by + because of a weird manner.
There was a problem hiding this comment.
It might be a special case in vscode, it was alright with vim and other terminal-base editors.
sadrasabouri
commented
Mar 13, 2021
| "playing cards hearts": "[♥]]]", | ||
| "playing cards hearts waterfall": "🂠🂱🂲🂳🂴🂵🂶🂷🂸🂹🂺🂻🂼🂽🂾", |
There was a problem hiding this comment.
These set waterfalls became well-ordered so that indexing will be easy for user.
sepandhaghighi
approved these changes
Mar 16, 2021
|
LGTM 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#95
new 1-line arts added: