Skip to content

Commit

Permalink
build: retry external binary downloads a few times (electron#24110)
Browse files Browse the repository at this point in the history
  • Loading branch information
MarshallOfSound authored and sentialx committed Jul 30, 2020
1 parent be7a222 commit 1819681
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions script/update-external-binaries.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,15 @@ def sha256(file_path):
return hash_256.hexdigest()


def download_binary(base_url, sha, binary_name):
def download_binary(base_url, sha, binary_name, attempt=3):
full_url = '{0}/{1}/{2}'.format(base_url, sha, binary_name)
temp_path = download_to_temp_dir(full_url, filename=binary_name, sha=sha)
return temp_path
try:
temp_path = download_to_temp_dir(full_url, filename=binary_name, sha=sha)
return temp_path
except Exception as e:
if attempt == 1:
raise e
return download_binary(base_url, sha, binary_name, attempt - 1)


def validate_sha(file_path, sha):
Expand Down

0 comments on commit 1819681

Please sign in to comment.