Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added entity annotations to agent reference #1363

Merged
merged 4 commits into from
Apr 17, 2019

Conversation

nixwiz
Copy link
Contributor

@nixwiz nixwiz commented Apr 13, 2019

Signed-off-by: Todd Campbell todd@toddcampbell.net

Description

Adds information on creating annotations attribute(s) within entities.

Motivation and Context

This PR goes along with this sensu-go PR #2877

Review Instructions

This was added to the latest (5.5) version of the docs, but unsure if/when the code PR will be merged.

Signed-off-by: Todd Campbell <todd@toddcampbell.net>
@apaskulin apaskulin added this to In Progress in sensu-docs via automation Apr 15, 2019
@apaskulin apaskulin added this to the Sensu Go 5.5.1 milestone Apr 15, 2019
Copy link
Contributor

@apaskulin apaskulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for opening this! I left one suggestion for the type.

It looks like this change will be part of the 5.5.1 release currently targeted for later this week, so we'll plan to merge this following the release.

content/sensu-go/5.5/reference/agent.md Outdated Show resolved Hide resolved
Co-Authored-By: nixwiz <todd@toddcampbell.net>
sensu-docs automation moved this from In Progress to Review Apr 15, 2019
Copy link
Contributor

@apaskulin apaskulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example | {{< highlight shell >}}# Command line example
sensu-agent start --annotations sensu.io/plugins/slack/config/webhook-url=https://hooks.slack.com/services/T00000000/B00000000/XXXXXXXXXXXXXXXXXXXXXXXX

example | {{< highlight shell >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference: sensu/sensu-go#2881

@apaskulin apaskulin merged commit 0ffdb73 into sensu:master Apr 17, 2019
sensu-docs automation moved this from Review to Done Apr 17, 2019
@nixwiz nixwiz deleted the 2554-entity-annotations branch April 19, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants