-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added entity annotations to agent reference #1363
Conversation
Signed-off-by: Todd Campbell <todd@toddcampbell.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thanks for opening this! I left one suggestion for the type.
It looks like this change will be part of the 5.5.1 release currently targeted for later this week, so we'll plan to merge this following the release.
Co-Authored-By: nixwiz <todd@toddcampbell.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example | {{< highlight shell >}}# Command line example | ||
sensu-agent start --annotations sensu.io/plugins/slack/config/webhook-url=https://hooks.slack.com/services/T00000000/B00000000/XXXXXXXXXXXXXXXXXXXXXXXX | ||
|
||
example | {{< highlight shell >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference: sensu/sensu-go#2881
Signed-off-by: Todd Campbell todd@toddcampbell.net
Description
Adds information on creating annotations attribute(s) within entities.
Motivation and Context
This PR goes along with this sensu-go PR #2877
Review Instructions
This was added to the latest (5.5) version of the docs, but unsure if/when the code PR will be merged.