Support CSS prefix being defined early #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 10, 2019 16:36
The CSS prefix that is part of the theme takes precedence over the prefix supplied to the converter. Deprecates $prefix parameter from Theme::asCss() It would be cumbersome to support a dynamic prefix at this late stage of the rendering. Tests updated to cover the following combinations. 1. Using the default theme or a supplied theme, with and without its own css prefix. 2. Using the default css prefix or a supplied prefix. 3. Using inline styling or CSS.
Unit tests now provide 100% code coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS prefix that is part of the theme takes precedence over the prefix
supplied to the converter.
Deprecates $prefix parameter from Theme::asCss()
It would be cumbersome to support a dynamic prefix at this late stage of
the rendering.
Tests updated to cover the following combinations.
Hopefully fixes #12