Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative css class naming doesn't work due to hardcoded values #12

Open
tommey opened this issue Mar 30, 2017 · 1 comment · May be fixed by #16
Open

Alternative css class naming doesn't work due to hardcoded values #12

tommey opened this issue Mar 30, 2017 · 1 comment · May be fixed by #16

Comments

@tommey
Copy link

tommey commented Mar 30, 2017

I tried to shorten the output by defining the css prefix as 'ac', but realized that it will never work due to the fact that the converter has ansi_color_ hardcoded and there is no connection between the Theme and the Converter.

$converter = new AnsiToHtmlConverter();
$converter->convert('some random cli output'); // returns classes with "ansi_color" prefix
$converter->getTheme()->asCss('css_prefix_for_ansi_color'); // returns styles with given prefix
@rquadling rquadling linked a pull request May 2, 2017 that will close this issue
@rquadling
Copy link

By the time the content has been converted, extracting the CSS with the new prefix is impossible.

If the prefix was supplied during construction of AnsiToHtmlConverter, that would then be possible.

I've created #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants