This repository has been archived by the owner on Feb 24, 2023. It is now read-only.
Restore undetermined state in Cache configuration #714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix a BC break introduced by #707.
Given the following code:
The headers generated by
HttpCacheListener
changed as following:Why? Because previously the Cache's properties were null until the user provide a value. In such state,
isPublic
returns false (althoughisPrivate
). And sometimes, null is expected (like thevary
array =>SensioFrameworkExtraBundle/src/EventListener/HttpCacheListener.php
Line 135 in b359690
The #707 PR introduce 2 changes:
setPublic
) does not expect a null value and convert null into something.It looks like, only the Cache configuration is affected. Other Configuration has already a default value defined for each property.
This PR restore the default
null
value for all properties and prevent the constructor to call the setter when the value is null.