Integrated nodemailer-sendgrid-transport as a package #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Total -- 100.72kb -> 93.83kb (6.84%) /packages/subscription-widget/server/static/template.png -- 71.49kb -> 65.69kb (8.11%) /packages/subscription-widget/server/static/sample-form.png -- 29.23kb -> 28.14kb (3.72%)
I copied the repo's content to this directory and removed files that weren't needed at that scope while ensuring a minimum of similarity in the structure used by other packages at the same scope.
This should help solve the following issues: - sendgrid/nodemailer-sendgrid-transport#65 - Close sendgrid/nodemailer-sendgrid-transport#25 It will assist with the following PRs: - sendgrid/nodemailer-sendgrid-transport#64 - sendgrid/nodemailer-sendgrid-transport#67
[ImgBot] optimizes images
But `npm test` fail due to an unfound `sendgrid` package, no idea how to solve that.
thinkingserious
added
the
status: code review request
|
|
|
Whoops, a tiny detail I that I let pass by, I'll try removing the bot's commits and perhaps close this PR and open a new one for cleanness sake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Closes nodemailer-sendgrid-transport#67.
Checklist
Short description of what this PR does:
nodemailer-sendgrid-transportpackage as an sub-package among others (while having it match and follow the structure/convention used by other sub-packages).If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.
Note: (as discussed in the PR mentioned above): the
npm testfails due to the usage of the formersendgridpackage in this codebase with some API changes and some sub-packages not available yet on NPM (causing allrequire('@sendgrid/xxx')to fail).