Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken image links on npm #1342

Merged
merged 2 commits into from Mar 2, 2022
Merged

docs: fix broken image links on npm #1342

merged 2 commits into from Mar 2, 2022

Conversation

IObert
Copy link
Contributor

@IObert IObert commented Feb 28, 2022

Fixes

Closes #1343

There's a broken link on the npm pages of each package because npm isn't aware of the notion of the monorepo. Hard-coding the URL to the image is the easiest solution to this problem.

https://www.npmjs.com/package/@sendgrid/client
Screenshot 2022-02-28 at 14 31 57

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works -> Not applicable
  • I have added the necessary documentation about the functionality in the appropriate .md file -> Not applicable
  • I have added inline documentation to the code I modified -> Not applicable

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@eshanholtz eshanholtz merged commit 723b753 into sendgrid:main Mar 2, 2022
@eshanholtz eshanholtz changed the title docs:fix broken image links on npm docs: fix broken image links on npm Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants