Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: follow-redirects npm's vulnerability #1335

Conversation

camelmasa
Copy link

Fixed: #1316

Fixes

Ref: axios/axios#4379

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@Sujay-shetty
Copy link

@eshanholtz could you please merge this PR as the criticality of this vulnerability is critical GHSA-74fj-2j2h-c42q

@camelmasa
Copy link
Author

@eshanholtz How is this ?

@childish-sambino
Copy link
Contributor

@camelmasa I see some test failures. Those will need to be fixed before this can be merged.

@childish-sambino childish-sambino added status: waiting for feedback waiting for feedback from the submitter type: security known security issue labels Feb 22, 2022
@childish-sambino
Copy link
Contributor

Fixed by #1347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for feedback waiting for feedback from the submitter type: security known security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please upgrade axios in the @sendgrid/client since it has security issue
4 participants