Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove mail.send helpers with on-behalf-of header #436

Merged
merged 4 commits into from Sep 24, 2021
Merged

chore: Remove mail.send helpers with on-behalf-of header #436

merged 4 commits into from Sep 24, 2021

Commits on Jul 20, 2021

  1. Remove mail.send helpers with on-behalf-of header 

    The sendgrid documentation (and my own findings) say that the mail.send endpoint
does not support using the `on-behalf-of` header.

[Documentation](
https://docs.sendgrid.com/api-reference/how-to-use-the-sendgrid-v3-api/on-behalf-of-subuser
)

Providing the `NewSendClientSubuser` in this SDK causes wasted time because it
sets the expectation that this is possible when it is not.

I also added guards to the `GetRequestSubuser` function to prevent people from
using it with the mail.send endpoint.
    @bjohnson-va
    bjohnson-va committed Jul 20, 2021
    Copy the full SHA
    27d6345 View commit details
    Browse the repository at this point in the history

  2. fix: missed a word

    @bjohnson-va
    bjohnson-va committed Jul 20, 2021
    Copy the full SHA
    c3bcc69 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. Merge branch 'main' into no-send-obo

    @JenniferMah
    JenniferMah committed Jul 29, 2021
    Copy the full SHA
    db53d46 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Remove guard and regression test

    @bjohnson-va
    bjohnson-va committed Sep 15, 2021
    Copy the full SHA
    2b9af2c View commit details
    Browse the repository at this point in the history