Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependency versions due to vulnerabilities found #64

Closed
wants to merge 2 commits into from

Conversation

Berkmann18
Copy link

License date changed to an up-to-date one
Resolves #25
Closes #63

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Update of the mocha, sendgrid and chai dependencies (mocha and sendgrid being the key ones in this change)
  • Bump of the year range in the license.

License date changed to an up-to-date one
This commit should resolve sendgrid#25 and sendgrid#63.
@thinkingserious
Copy link
Contributor

Thanks @Berkmann18,

This is now on our backlog for review.

@Berkmann18
Copy link
Author

You're welcome :).

I updated some packages due to a security vulnerability raised in [sendgrid#65](sendgrid#65) and as a follow up to the PR [sendgrid#64](sendgrid#64) (where I added a basic issue template and one use case).
@Berkmann18 Berkmann18 mentioned this pull request Jul 5, 2018
6 tasks
Berkmann18 added a commit to Berkmann18/sendgrid-nodejs that referenced this pull request Jul 27, 2018
I also refactored some of it such that it contains only the necessary
files, as well as follow the structure that the other sub-packages
follow.

This commit should help with the PRs:
- [NST#67](sendgrid/nodemailer-sendgrid-transport#67)
- [NST#64](sendgrid/nodemailer-sendgrid-transport#64)

And the following issues:
- [NST#65](sendgrid/nodemailer-sendgrid-transport#65)
- [NST#25](sendgrid/nodemailer-sendgrid-transport#25)

The problem I face despit this commit being here is that some
sub-packages require the old `sendgrid` package which works differently
then this one.
@Berkmann18 Berkmann18 closed this Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sendgrid dependency to 2.0 Vulnerabilities in dependencies
2 participants