Skip to content

Commit

Permalink
Bump @types/jasmine from 4.3.6 to 5.1.4 (#1383)
Browse files Browse the repository at this point in the history
* Bump @types/jasmine from 4.3.6 to 5.1.4

Bumps [@types/jasmine](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jasmine) from 4.3.6 to 5.1.4.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jasmine)

---
updated-dependencies:
- dependency-name: "@types/jasmine"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bumped prettier and puppeteer

* Fixed file formatting for prettier v3.2.5

* Updated CircleCI orbs and added missing npm install step.

* Added override to enable using Jasmine 5.

Since Karma is deprecated, there's not going to be an update for karma-jasmine. An override is the only way to upgrade until the migration to the Jasmine web runner (which - according to the deprecation annoncement - possibly requires an Angular update).
Workaround from karma-runner/karma-jasmine#333.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shir Bar Lev <shirblc@gmail.com>
  • Loading branch information
dependabot[bot] and shirblc committed Feb 4, 2024
1 parent ea4ecbd commit 3580555
Show file tree
Hide file tree
Showing 5 changed files with 52 additions and 38 deletions.
12 changes: 9 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,21 @@
version: 2.1
orbs:
node: circleci/node@1.1
browser-tools: circleci/browser-tools@1.4.6
cypress: cypress-io/cypress@1
codecov: codecov/codecov@3.1.1
cypress: cypress-io/cypress@3.3.0
codecov: codecov/codecov@4.0.1
jobs:
format:
docker:
- image: cimg/node:lts
steps:
- checkout
- restore_cache:
key: my-project-{{ .Branch }}-{{ checksum "package-lock.json" }}
- run: npm install
- save_cache:
key: my-project-{{ .Branch }}-{{ checksum "package-lock.json" }}
paths:
- "node_modules"
- run: npx prettier --check .
test:
docker:
Expand Down
4 changes: 2 additions & 2 deletions e2e/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"compilerOptions": {
"target": "es5",
"lib": ["es5", "dom"],
"types": ["cypress", "node"],
"types": ["cypress", "node"]
},
"include": ["./**/*.ts"],
"include": ["./**/*.ts"]
}
54 changes: 28 additions & 26 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 9 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,19 @@
"build": "node env-config.js",
"start": "node server.js"
},
"overrides": {
"karma-jasmine": {
"jasmine-core": "^4.1.0 || ^5.0.0"
}
},
"author": "Shir Bar Lev",
"devDependencies": {
"@rollup/plugin-commonjs": "^25.0.7",
"@rollup/plugin-node-resolve": "^15.2.3",
"@rollup/plugin-typescript": "^11.1.6",
"@rollup/stream": "^3.0.1",
"@types/auth0-js": "^9.21.5",
"@types/jasmine": "^4.3.6",
"@types/jasmine": "^5.1.4",
"@types/node": "^20.11.16",
"autoprefixer": "^10.4.17",
"browser-sync": "^3.0.2",
Expand All @@ -33,6 +38,7 @@
"gulp-replace": "^1.1.4",
"gulp-sass": "^5.1.0",
"gulp-terser": "^2.1.0",
"jasmine-core": "^5.1.1",
"jasmine-spec-reporter": "^7.0.0",
"karma": "^6.4.2",
"karma-chrome-launcher": "^3.2.0",
Expand All @@ -45,8 +51,8 @@
"karma-viewport": "^1.0.9",
"magic-string": "^0.30.6",
"postcss": "^8.4.33",
"prettier": "^3.2.4",
"puppeteer": "^21.10.0",
"prettier": "^3.2.5",
"puppeteer": "^21.11.0",
"rollup": "^4.9.6",
"rollup-plugin-istanbul": "^5.0.0",
"sass": "^1.70.0",
Expand Down
8 changes: 4 additions & 4 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"paths": {
"@app/*": ["./src/app/*"],
"@env/*": ["./src/environments/*"],
"@tests/*": ["./src/tests/*"],
"@tests/*": ["./src/tests/*"]
} /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */,
// "rootDirs": [], /* List of root folders whose combined content represents the structure of the project at runtime. */
// "typeRoots": [], /* List of folders to include type definitions from. */
Expand All @@ -65,12 +65,12 @@
"emitDecoratorMetadata": true /* Enables experimental support for emitting type metadata for decorators. */,

/* Advanced Options */
"forceConsistentCasingInFileNames": true /* Disallow inconsistently-cased references to the same file. */,
"forceConsistentCasingInFileNames": true /* Disallow inconsistently-cased references to the same file. */
},
"include": ["src/**/*.ts"],
"exclude": ["e2e/tsconfig.json"],
"angularCompilerOptions": {
"enableIvy": true,
"enableResourceInlining": false,
},
"enableResourceInlining": false
}
}

0 comments on commit 3580555

Please sign in to comment.