Fix fail phase not always triggered #3180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanseltime
force-pushed
the
fix-fail-phase-not-always-triggered
branch
from
46dc618
to
e14375e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3146
Summary
Adds a set of integration tests where we throw an non semantic-release error from each plugin phase and check to see if the fail plugin is called.
Currently, the second commit is added where I remove the filter that only triggers failures for "semantic-release" errors. This was to prove that the tests do pass when the real error is passed. This can be removed if we want to. Please let me know. It fails on all accounts for the non-fixed errors.