Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(github-actions): add triggering semantic-release on private repositories #2794

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jimmiebee
Copy link

@jimmiebee jimmiebee commented May 11, 2023

This PR adds a docs regarding sample workflow trigger for private repositories.

@jimmiebee jimmiebee changed the title docs: add triggering semantic-release on private repositories WIP docs: add triggering semantic-release on private repositories May 11, 2023
@jimmiebee jimmiebee marked this pull request as draft May 11, 2023 19:05
@jimmiebee jimmiebee changed the title WIP docs: add triggering semantic-release on private repositories docs(github-actions): add triggering semantic-release on private repositories May 11, 2023
@jimmiebee jimmiebee marked this pull request as ready for review May 11, 2023 19:20
@travi
Copy link
Member

travi commented May 12, 2023

could you clarify the use case that you are trying to capture with this contribution? what do you mean by private in this case?

setting "private": true in the package.json prevents publishing a package altogether. in a way, that property is named poorly because it truly means something closer to "this project is not a package". if you are targeting projects that are not packages with this contribution, i dont think that is clear with this iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants