Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: choose branch instead of prBranch when noCi is true #1599

Closed
wants to merge 1 commit into from

Conversation

dcneiner
Copy link

@dcneiner dcneiner commented Jul 10, 2020

Resolves #1596

Open to any feedback on this PR, including if it is not a good change for the project and just needs to be closed.

Question on the tests: I started to add a new test for the change, but found an existing assertion that prior to #1521 seemed to be verifying noCi wouldn't reject even if isPr were true. Was the change I made sufficient or would you like a separate test for this use case?

This also has me wondering if there should/could be another way to provide what semantic-release uses as the branch for any situations where inferring it from envCi may not provide the correct answer?

@dcneiner
Copy link
Author

The more I think and look at this, I'm beginning to think the issue may be in env-ci when used on Github Actions. And given a recent fix in semantic-release-github-pr I think my changes will just make matters worse. I'm sorry I didn't come to this understanding prior to opening the issue and PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent branch to ciBranch causing issues for --dry-run --no-ci in Github Actions
1 participant