fix: choose branch instead of prBranch when noCi is true #1599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1596
Open to any feedback on this PR, including if it is not a good change for the project and just needs to be closed.
Question on the tests: I started to add a new test for the change, but found an existing assertion that prior to #1521 seemed to be verifying
noCi
wouldn't reject even ifisPr
weretrue
. Was the change I made sufficient or would you like a separate test for this use case?This also has me wondering if there should/could be another way to provide what semantic-release uses as the branch for any situations where inferring it from
envCi
may not provide the correct answer?