Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links to commits in release notes use git+https: protocol #539

Closed
gr2m opened this issue Nov 30, 2017 · 6 comments
Closed

Links to commits in release notes use git+https: protocol #539

gr2m opened this issue Nov 30, 2017 · 6 comments
Assignees
@pvdlg

Comments

@gr2m
Copy link
Member

gr2m commented Nov 30, 2017

image
@pvdlg pvdlg self-assigned this Nov 30, 2017
@pvdlg pvdlg mentioned this issue Nov 30, 2017
Merged
@rodrigobdz rodrigobdz mentioned this issue Nov 23, 2018
Closed
@rodrigobdz
Copy link

This issue is still happening in https://github.com/okonet/lint-staged/releases as described in lint-staged/lint-staged#546. @gr2m Could you reopen this issue?

@gr2m
Copy link
Member Author

gr2m commented Nov 23, 2018

Thanks for reporting the issue!

@gr2m gr2m reopened this Nov 23, 2018
@pvdlg
Copy link
Member

pvdlg commented Nov 23, 2018

This is happening because that project uses version 12: https://github.com/okonet/lint-staged/blob/fcb774b1ff46bf072e77b757a6b1133bb72b596c/.travis.yml#L24

After upgrading to the latest version 15 it will works.

@pvdlg pvdlg closed this as completed Nov 23, 2018
@okonet
Copy link

okonet commented Nov 23, 2018

We had a reason to pin the version although I can not remember what it was

@pvdlg
Copy link
Member

pvdlg commented Nov 23, 2018

Version is really old (we are version 15) and many fixes/features have been added since then. We might consider delivering fixes for the previous major release (e.g. version 15 when we release 16) but we won't maintain a version that is so old as 12....

@okonet
Copy link

okonet commented Nov 24, 2018

That’s understandable. I’m going to upgrade to latest and see if it still works for us.

rodrigobdz added a commit to rodrigobdz/lint-staged that referenced this issue Nov 24, 2018
@rodrigobdz
Chore: Upgrade semantic-release to v15
f3a335c 
Should fix lint-staged#546 and semantic-release/semantic-release#539 where links in releases section where using git+https protocol.
rodrigobdz added a commit to rodrigobdz/lint-staged that referenced this issue Nov 24, 2018
@rodrigobdz
Chore: Upgrade semantic-release to v15
dc27de3 
Should fix lint-staged#546 and semantic-release/semantic-release#539 where links in releases section were using git+https protocol.
@rodrigobdz rodrigobdz mentioned this issue Nov 24, 2018
Merged
okonet pushed a commit to lint-staged/lint-staged that referenced this issue Nov 26, 2018
@rodrigobdz @okonet
chore: Upgrade semantic-release to latest (#548)
30576d6 
* Chore: Upgrade semantic-release to v15

Should fix #546 and semantic-release/semantic-release#539 where links in releases section were using git+https protocol.

* Chore: Upgrade semantic-release to latest

Use latest instead of a fixed version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pvdlg pvdlg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@okonet @gr2m @pvdlg @rodrigobdz