Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken links in Releases #546

Closed
rodrigobdz opened this issue Nov 22, 2018 · 8 comments · Fixed by #548
Closed

Broken links in Releases #546

rodrigobdz opened this issue Nov 22, 2018 · 8 comments · Fixed by #548
Labels
invalid released wontfix

Comments

@rodrigobdz
Copy link
Contributor

Description

Links to issues and pull requests in Releases are broken.
They have this format: http://git+https/github.com/okonet/lint-staged/issues/542

Steps to reproduce

Click on the link to the issue #542 in 8.0.5 release.
It happens not only with links in release 8.0.5.

Debug Logs

expand to view

image

Environment

  • OS: macOS Mojave
  • Browser: Google Chrome Version 70.0.3538.102 (Official Build) (64-bit)
@okonet
Copy link
Collaborator

okonet commented Nov 23, 2018

Looks like https://github.com/semantic-release/semantic-release issue. Can you please report there?

@okonet okonet closed this as completed Nov 23, 2018
@rodrigobdz
Copy link
Contributor Author

It has already been reported there semantic-release/semantic-release#539.

@okonet
Copy link
Collaborator

okonet commented Nov 23, 2018

Nice! Thanks!

@rodrigobdz rodrigobdz mentioned this issue Nov 23, 2018
Closed
@rodrigobdz
Copy link
Contributor Author

Glad to help.

@okonet
Copy link
Collaborator

okonet commented Nov 24, 2018

Do you want to submit a PR to bump the version?

@rodrigobdz
Copy link
Contributor Author

I'll do it right away.

rodrigobdz added a commit to rodrigobdz/lint-staged that referenced this issue Nov 24, 2018
@rodrigobdz
Chore: Upgrade semantic-release to v15
f3a335c 
Should fix lint-staged#546 and semantic-release/semantic-release#539 where links in releases section where using git+https protocol.
rodrigobdz added a commit to rodrigobdz/lint-staged that referenced this issue Nov 24, 2018
@rodrigobdz
Chore: Upgrade semantic-release to v15
dc27de3 
Should fix lint-staged#546 and semantic-release/semantic-release#539 where links in releases section were using git+https protocol.
@rodrigobdz rodrigobdz mentioned this issue Nov 24, 2018
Merged
@rodrigobdz
Copy link
Contributor Author

I had a typo in the commit message from f3a335c, you can ignore it. I corrected it in dc27de3 but somehow GitHub is still showing the first commit.

okonet pushed a commit that referenced this issue Nov 26, 2018
@rodrigobdz @okonet
chore: Upgrade semantic-release to latest (#548)
30576d6 
* Chore: Upgrade semantic-release to v15

Should fix #546 and semantic-release/semantic-release#539 where links in releases section were using git+https protocol.

* Chore: Upgrade semantic-release to latest

Use latest instead of a fixed version.
@okonet
Copy link
Collaborator

okonet commented Jan 28, 2019

🎉 This issue has been resolved in version 8.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid released wontfix
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore: Upgrade semantic-release to latest rodrigobdz/lint-staged
2 participants
@okonet @rodrigobdz