#1862 #1866 remove usages of deprecated capability "javascriptEnabled"

I didn't find any replacement. Is it enabled by default in all browsers?
selenide · Jun 24, 2022 · 4bbb4d4 · 4bbb4d4
1 parent 87ef1ce
commit 4bbb4d4
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 7 deletions.
diff --git a/src/main/java/com/codeborne/selenide/webdriver/AbstractDriverFactory.java b/src/main/java/com/codeborne/selenide/webdriver/AbstractDriverFactory.java
@@ -25,7 +25,6 @@
 import static org.openqa.selenium.remote.CapabilityType.BROWSER_VERSION;
 import static org.openqa.selenium.remote.CapabilityType.PAGE_LOAD_STRATEGY;
 import static org.openqa.selenium.remote.CapabilityType.PROXY;
-import static org.openqa.selenium.remote.CapabilityType.SUPPORTS_JAVASCRIPT;
 import static org.openqa.selenium.remote.CapabilityType.TAKES_SCREENSHOT;
 import static org.openqa.selenium.remote.CapabilityType.UNHANDLED_PROMPT_BEHAVIOUR;
 
@@ -76,7 +75,6 @@ protected <T extends MutableCapabilities> T createCommonCapabilities(T capabilit
     if (browser.supportsInsecureCerts()) {
       capabilities.setCapability(ACCEPT_INSECURE_CERTS, true);
     }
-    capabilities.setCapability(SUPPORTS_JAVASCRIPT, true);
     capabilities.setCapability(TAKES_SCREENSHOT, true);
     capabilities.setCapability(UNHANDLED_PROMPT_BEHAVIOUR, "accept");
 

diff --git a/src/test/java/com/codeborne/selenide/impl/CleanupTest.java b/src/test/java/com/codeborne/selenide/impl/CleanupTest.java
@@ -22,7 +22,7 @@ void cleansWebDriverExceptionMessage() {
       "Session ID: 610138404f5c180a4f3153785e66c528\n" +
       "Driver info: org.openqa.selenium.chrome.ChromeDriver\n" +
       "Capabilities [{platform=LINUX, chrome.chromedriverVersion=26.0.1383.0, " +
-      "javascriptEnabled=true, browserName=chrome, rotatable=false, locationContextEnabled=false, " +
+      "browserName=chrome, rotatable=false, locationContextEnabled=false, " +
       "version=24.0.1312.56, cssSelectorsEnabled=true, databaseEnabled=false, " +
       "browserConnectionEnabled=false, webStorageEnabled=true, nativeEvents=true, applicationCacheEnabled=false, " +
       "takesScreenshot=true}]";

diff --git a/src/test/java/com/codeborne/selenide/webdriver/ChromeDriverFactoryTest.java b/src/test/java/com/codeborne/selenide/webdriver/ChromeDriverFactoryTest.java
@@ -61,7 +61,6 @@ void mergesDefaultCapabilities() {
 
     assertThat(options.getCapability("acceptInsecureCerts")).isEqualTo(TRUE);
     assertThat(options.getCapability("browserName")).isEqualTo("chrome");
-    assertThat(options.getCapability("javascriptEnabled")).isEqualTo(TRUE);
     assertThat(options.getCapability("takesScreenshot")).isEqualTo(TRUE);
   }
 

diff --git a/src/test/java/com/codeborne/selenide/webdriver/EdgeDriverFactoryTest.java b/src/test/java/com/codeborne/selenide/webdriver/EdgeDriverFactoryTest.java
@@ -61,7 +61,6 @@ void mergesDefaultCapabilities() {
 
     assertThat(options.getCapability("acceptInsecureCerts")).isEqualTo(TRUE);
     assertThat(options.getCapability("browserName")).isEqualTo("MicrosoftEdge");
-    assertThat(options.getCapability("javascriptEnabled")).isEqualTo(TRUE);
     assertThat(options.getCapability("takesScreenshot")).isEqualTo(TRUE);
   }
 

diff --git a/src/test/java/com/codeborne/selenide/webdriver/FirefoxDriverFactoryTest.java b/src/test/java/com/codeborne/selenide/webdriver/FirefoxDriverFactoryTest.java
@@ -50,7 +50,6 @@ void mergesDefaultCapabilities() {
 
     assertThat(options.getCapability("acceptInsecureCerts")).isEqualTo(TRUE);
     assertThat(options.getCapability("browserName")).isEqualTo("firefox");
-    assertThat(options.getCapability("javascriptEnabled")).isEqualTo(TRUE);
     assertThat(options.getCapability("takesScreenshot")).isEqualTo(TRUE);
   }
 

diff --git a/src/test/java/com/codeborne/selenide/webdriver/SafariDriverFactoryTest.java b/src/test/java/com/codeborne/selenide/webdriver/SafariDriverFactoryTest.java
@@ -37,7 +37,6 @@ void mergesDefaultCapabilities() {
     SafariOptions options = factory.createCapabilities(config, browser, null, new File("/tmp/downloads-folder-12345"));
     assertThat(options.getCapability("acceptInsecureCerts")).isEqualTo(TRUE);
     assertThat(options.getCapability("browserName")).isEqualTo("safari");
-    assertThat(options.getCapability("javascriptEnabled")).isEqualTo(TRUE);
     assertThat(options.getCapability("takesScreenshot")).isEqualTo(TRUE);
   }
 }