Adding options for multiple decorators #6309
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation only allows to overwrite the adapters.
If a user only wants to add a decorator they have to call
Defaults.apply(options)
prior toselect2()
to build the default adapters with its optional decorators based on the given options and they have to import the utils module to build it.The problem is, that since you only had the option to change the whole adapter, all the plugins out there build their own adapters, without adding the default decorators.
That way you cannot even combine two whole plugin adapters.
It's better to incentivize devs to actually use the decorator system!
With this new implementation you just have to pass an array of decorators, which are added in order to the default adapters (based on the current options)
This looks like a dead project, so here's a polyfill for those who want to use it while this isn't merged
This pull request includes a
The following changes were made
dataAdapterDecorators
resultsAdapterDecorators
dropdownAdapterDecorators
selectionAdapterDecorators