Bugfix / Support data-placeholder values which consist solely of digits #6297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a
The following changes were made
Validate placeholder type as an
object
instead of checking if it is astring
. This fixes a bug where placeholder is defined as an inline attributedata-placeholder
which consists solely of digits. In this case the value type becomes anumber
which breaks the testtypeof placeholder === 'string'
and causes the placeholder to get ignored.