Replace attr with getAttribute and setAttribute
#6227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
force-pushed
the
remove-jquery/attr
branch
3 times, most recently
from
2e974ac
to
6a56338
Compare
|
Can you rebase this with the latest changes on develop (I merged in your PR to fix the CI, thank you!) and back out the |
|
@kevin-brown Thanks! Sure will do. |
p8
force-pushed
the
remove-jquery/attr
branch
from
6a56338
to
9241762
Compare
|
@kevin-brown I've rebased and removed the dist changes. |
p8
force-pushed
the
remove-jquery/attr
branch
from
8d399fe
to
8e56ecd
Compare
This replaces jQuery's `attr` function with the vanilla JavaScript `getAttribute` and `setAttribute`.
This replaces jQuery's `attr` function with the vanilla JavaScript `getAttribute` and `setAttribute`.
p8
force-pushed
the
remove-jquery/attr
branch
from
8e56ecd
to
0b0e790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a
The following changes were made
attrfunction with the vanilla JavaScriptgetAttributeandsetAttribute.This is related to: #6196