Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nice to have] multisig preventing signing with wrong key #286

Merged
merged 5 commits into from Jun 14, 2023

Conversation

BrandonWeng
Copy link
Contributor

@BrandonWeng BrandonWeng commented Jun 13, 2023

Describe your changes and provide context

Doesn't seem to be absolutely necessary since it would just fail when broadcasting, more of an UI improvement. We can wait until 3.0.4 is out and then merging

Copying from: cosmos/cosmos-sdk#12548

Testing performed to validate your change

unit tests

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #286 (ede9ef4) into main (df2cf22) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head ede9ef4 differs from pull request most recent head f716336. Consider uploading reports for the commit f716336 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   54.98%   54.95%   -0.03%     
==========================================
  Files         619      619              
  Lines       51524    51549      +25     
==========================================
  Hits        28329    28329              
- Misses      21162    21187      +25     
  Partials     2033     2033              
Impacted Files Coverage Δ
x/auth/client/cli/tx_sign.go 0.00% <0.00%> (ø)

@BrandonWeng
Copy link
Contributor Author

Just tested this on a local node too
image
image

@BrandonWeng BrandonWeng enabled auto-merge (squash) June 14, 2023 15:30
@BrandonWeng BrandonWeng merged commit 19db353 into main Jun 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants