fix: handle error in response #925
Merged
+92
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhansen2
force-pushed
the
cyx-fix-handle-error-in-response
branch
from
ad5ec34 to
2cdf54a
Compare
achille-roussel
approved these changes
Jun 3, 2022
|
Guys the same issue happens in all other request... (we are seeing it in ListGroups). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using this in production we ran into a panic where DescribeConfigs resulted in a *net.OpError (due to the kafka cluster rebalancing).
The panic was because we cast everything to *Response even though there are cases where it's an error. Handling this case with an error type seemed more appropriate.
This is a recreation of #890 which maintains the original authors commits.