work around incorrect v1 metadata #1172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func (s *subscriptionBackwardsCompat) FromBytes(b []byte) error { | ||
| // This type is only intended to maintain backwards compatibility with | ||
| // this library and support other clients in the wild sending | ||
| // version 1 supscription data without OwnedPartitionsy |
There was a problem hiding this comment.
Suggested change
| // version 1 supscription data without OwnedPartitionsy | |
| // version 1 subscription data without OwnedPartitions |
| } | ||
|
|
||
| type subscriptionBackwardsCompat struct { | ||
| Version int16 `kafka:"min=v0,max=v1"` |
There was a problem hiding this comment.
Style wise I'm on the fence of adding an addition type for this vs. handling this in Subscriptions's FromBytes method. What do you think?
| } | ||
| version := readInt16(b[0:2]) | ||
| err := protocol.Unmarshal(b, version, s) | ||
| if err != nil && version >= 1 && errors.Is(err, io.ErrUnexpectedEOF) { |
There was a problem hiding this comment.
Do you think we could either move the comment about backwards capability above here or make these checks in the if statement a separate function like isBackwardsCompatible? I had a bit of a hard time understanding it the way the code is structured now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #1156