Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warning: The value prop is required for the <Context.Provider> #1142

Closed
wants to merge 2 commits into from

Conversation

billyct
Copy link

@billyct billyct commented Feb 8, 2021

Overview

with react 17.x, use the TableRow component will Warning: The value prop is required for the <Context.Provider>

Fixes #1140

@mifi mifi mentioned this pull request Apr 21, 2021
@stale
Copy link

stale bot commented Jun 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wont-fix label Jun 16, 2021
@mifi
Copy link

mifi commented Jun 17, 2021

@Stale This is not an issue, it’s a pr and it should be merged, not closed

@stale stale bot removed the wont-fix label Jun 17, 2021
@netlify
Copy link

netlify bot commented Jul 14, 2021

✔️ Deploy Preview for evergreen-storybook ready!

🔨 Explore the source changes: d13c41b

🔍 Inspect the deploy log: https://app.netlify.com/sites/evergreen-storybook/deploys/60ef3e375c6bbe00085b0817

😎 Browse the preview: https://deploy-preview-1142--evergreen-storybook.netlify.app

@@ -99,7 +99,7 @@ const TableRow = memo(
const height = rest.height || themeHeight

return (
<TableRowProvider height={height}>
<TableRowProvider value={height}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to verify that this doesn't introduce any issues, given that it's been like this for a long time and things "work"

@mshwery
Copy link
Contributor

mshwery commented Jul 14, 2021

Screen Shot 2021-07-14 at 2 49 37 PM

Looks like it does mess things up a little. I wonder if we can/should get rid of the context entirely since it's been broken forever.

Should look like this:
Screen Shot 2021-07-14 at 2 49 32 PM

@mshwery
Copy link
Contributor

mshwery commented Jul 14, 2021

The fix is to remove the context altogether since it is inert but causing extra work! #1256

Thank you for pointing this out and for your initial fix @billyct

@mshwery mshwery closed this Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table.Row - Context.Provider missing 'value' prop
3 participants