Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AVX512FP16 instruction set #52

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support AVX512FP16 instruction set #52

wants to merge 2 commits into from

Conversation

zchee
Copy link

@zchee zchee commented Sep 24, 2021

Support AVX512FP16 instruction set.

ref: klauspost/cpuid@6903d4066801

@zchee
go.mod: upgrade klauspost/cpuid/v2 to v2.0.9 for support AVX512FP16
d0f3250 
ref: klauspost/cpuid@6903d4066801

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@zchee
cpu: support AVX512FP16 instruction set
e972a81 
ref: klauspost/cpuid@6903d4066801

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@kalamay
Copy link
Contributor

kalamay commented Sep 25, 2021

Hi @zchee thanks for the PR! It does seem that we never originally put a Makefile build dependency between the cpu/cpu.go file and the generated *.s files. When a new X86Feature bit flag is introduced—AVX512FP16 in this case—it will change the values of the subsequent flags due to the use of iota. This is fine, but we need to regenerate the *.s files as they use the same bit flags during build time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zchee @kalamay